Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retagg oauth2_proxy #126

Merged
merged 1 commit into from
Aug 16, 2018
Merged

Retagg oauth2_proxy #126

merged 1 commit into from
Aug 16, 2018

Conversation

indyfree
Copy link
Contributor

Towards https://github.com/giantswarm/giantswarm/issues/3958

Use community image that supports token renewal with OICD.

See bitly/oauth2_proxy#621

@indyfree indyfree self-assigned this Aug 16, 2018
@indyfree indyfree requested a review from a team August 16, 2018 09:08
corest
corest approved these changes Aug 16, 2018
View reviewed changes
Copy link
Contributor

@corest corest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi you don't need review for retagger

@fgimenez
Copy link
Contributor

We will need to create the image in aliyun registry. @puja108 can you create an user for @indyfree ?

@indyfree
Copy link
Contributor Author

To understand correctly @fgimenez. We have the Cirlce aliyun retag job in place but need to create the image in aliyun manually first?

retagger/.circleci/config.yml

Lines 31 to 33 in bd22e7f

retagAliyun:
environment:
REGISTRY: "registry-intl.cn-shanghai.aliyuncs.com"

@fgimenez
Copy link
Contributor

@indyfree yes, it is the same as with quay, we have a job for each registry and we need to create the repository before pushing images.

rossf7
rossf7 approved these changes Aug 16, 2018
View reviewed changes
Copy link
Contributor

@rossf7 rossf7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once Aliyun image is set up.

@indyfree indyfree merged commit d5c5a07 into master Aug 16, 2018
@indyfree indyfree deleted the add_oauth2_proxy branch August 16, 2018 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossf7 rossf7 rossf7 approved these changes

@corest corest corest approved these changes

Assignees

@indyfree indyfree

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@indyfree @fgimenez @rossf7 @corest