Dot net standard #257

EranOfer · 2019-10-16T08:02:24Z

No description provided.

…gacy, Logging.Legacy

…ix silo

…gya/microdot into us/95878.infra.orleans.2_20.5

fix seriveProxy provider whwn sorce is local

…throw meaningfull exception if failes)

…ixed by Orleans

…ed issues

EranOfer · 2019-10-16T08:18:40Z

tests/Gigya.Microdot.UnitTests/Discovery/ConsulSimulator.cs

@@ -321,8 +321,8 @@ private async Task SetResponse(HttpListenerContext context, string serviceName,

        public void Dispose()
        {
-            _consulListener.Close();
-            ((IDisposable)_consulListener)?.Dispose();
+            //_consulListener.Close();


Should understand the issue.
dispose should not throw an exception or cause other side effects

EranOfer · 2019-10-16T08:21:04Z

Sample/CalculatorService.Client/Discovery.config

@@ -2,7 +2,7 @@
 <configuration>
  <Discovery>
    <Services>
-      <CalculatorService Source="Local" />
+      <CalculatorService Source="Config" Hosts="127.0.0.1" DefaultPort="12323"/>


EranOfer · 2019-10-16T08:26:01Z

Gigya.ServiceContract/Gigya.ServiceContract.csproj

+    <TargetFramework>netstandard2.0</TargetFramework>
+    <GenerateAssemblyInfo>false</GenerateAssemblyInfo>
+    <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
+    <PackageVersion>7.0.3-beta</PackageVersion>


The package version should be 6.
The build server Identify branch is not master and therefor create a beta version.

Also, we want one nuspec file that controls the version. ( microdot come as a full package)

EranOfer · 2019-10-16T08:29:06Z

Gigya.Microdot.SharedLogic/CurrentApplicationInfo.cs

@@ -69,13 +69,11 @@ public CurrentApplicationInfo(string name, string instanceName = null, Version i
            if (name == null)
                throw new ArgumentNullException(nameof(name));

-            OsUser = WindowsIdentity.GetCurrent().Name;
+            OsUser = "N/A";


can you find a way in Linux to get the Current user?

EranOfer · 2019-10-16T08:32:02Z

Gigya.Microdot.SharedLogic/CurrentApplicationInfo.cs

-            // ReSharper disable once PossibleNullReferenceException
-            IsRunningAsWindowsService = Environment.OSVersion.Platform == PlatformID.Win32NT &&
-                WindowsIdentity.GetCurrent().Name == @"NT AUTHORITY\SYSTEM";
+            IsRunningAsWindowsService = false;


@daniel-lamberger can we remove WindowsService support?

Environment.UserName

EranOfer · 2019-10-16T08:43:41Z

Gigya.Microdot.Hosting/HttpService/HttpServiceListener.cs

@@ -296,6 +297,10 @@ private async Task HandleRequest(HttpListenerContext context)
                    }
                }
            }
+            finally
+            {


we need more investigation to understand doker in Linux

EranOfer · 2019-10-16T08:50:30Z

Gigya.Microdot.Configuration/FileBasedConfigItemsSource.cs

@@ -71,7 +71,7 @@ public async Task<ConfigItemsCollection> GetConfiguration()
                                       .Select(match => new
                                       {
                                           Placehodler = "%" + match.Groups[1].Value + "%",
-                                           Value = _environmentVariableProvider.GetEnvironmentVariable(match.Groups[1].Value)
+                                           Value = _environmentVariableProvider.GetEnvironmentVariable(match.Groups[1].Value.ToUpper())


Can you please move the ToUpper to the where.

add readme that describes our environment variable format ( Upper case key, lower case value )

EranOfer · 2019-10-16T08:53:15Z

Gigya.Microdot.Configuration/ConfigurationFilesWatcher.cs

@@ -65,7 +65,28 @@ public ConfigurationFilesWatcher(IConfigurationLocationsParser configurationLoca

        private void CreateRootWatcher()
        {
-
+            var usePolling = Environment.GetEnvironmentVariable("GIGYA_CONFIG_USE_POLLING");


@daniel-lamberger what do you think about polling instead of Watcher.
(due to docker on windows have no support in file system Watcher)

EranOfer · 2019-10-16T08:59:01Z

tests/Gigya.Microdot.UnitTests/Serialization/ExceptionSerializationTests.cs

@@ -97,7 +97,7 @@ public void OrleansSerialization_CustomerFacingException_IsEquivalent()
        /// [DONE] #ORLEANS20 - I don't now why, but round/trip for HttpRequestException is loosing stack trace...
        /// https://github.com/dotnet/orleans/issues/5876
        /// </summary>
-        [Test]
+        [Test, Ignore("Waiting for issue to be fixed by Orleans")]


let's try to find other solution for that

EranOfer · 2019-10-16T08:59:39Z

tests/Gigya.Microdot.UnitTests/ServiceProxyTests/BehaviorTests.cs

@@ -356,7 +354,7 @@ public async Task RequestContextOverrideShouldFailOnFirstAttempt()

                //Disable  TracingContext.SetRequestID("1");

-                CallContext.FreeNamedDataSlot("#ORL_RC");
+                TracingContext.ClearContext();// CallContext.FreeNamedDataSlot("#ORL_RC");


remove zombi code :P

…n outgoing requests

…not passed in

chirlin-sap and others added 30 commits May 16, 2019 19:17

95878, install Orleans 2.3.3 (latest stable)

bbfaa83

95878, small advance with Legacy abstraction: Core.Legacy, Runtime.Le…

fdbf30a

…gacy, Logging.Legacy

95878, solving DI issues

bc45ab9

change ServiceLifetime.Scoped to be InTransientScope

daa6ac6

temp code for binding (IKeyedService<,> to multiple implementations

85c6cee

95878, bring it up so far without interceptor

9256e2d

start refactor unwrap legacy to builder

2a5b215

refactor temp code

308b56e

add Install-Package Microsoft.Orleans.OrleansCodeGenerator.Build to f…

fa043d5

…ix silo

Refactor to add silo initialization in configurable way

272216f

Refactor add logger and start using orleance builder

88217ca

refactor orelance builder

1b564a6

new orleans RequestContext

64ff56c

add Copyright

a488a57

95878, CurrentApplicationInfo refactor remove static

0d6aa8d

Merge branch 'us/95878.infra.orleans.2_20.5' of https://github.com/gi…

81c04f4

…gya/microdot into us/95878.infra.orleans.2_20.5

start fixing test

547f4e3

fix test remove app domain

5f33279

95878, fix event related tests and config verification tests

387d4f9

95878, merge from remote

3758381

95878, fix tests code

94ab97e

Refactor tests

7f7b6c7

fix test

babe76c

95878, refactor publishing event, convert to factory

da7701c

fix more test

fca752c

95878, fix recompilation w/o changes

d767829

fix silo stop

fb9266a

fix tests

a237f33

fix seriveProxy provider whwn sorce is local

95878, fix refs after install

f877757

remove dead code from silohost and continue fixing the test

da64e83

Yaron Thurm added 12 commits September 26, 2019 16:23

updated nuget version

a24ebcb

JSON_COMPATIBILITY_SHIM

f875def

nuget

8d71fd3

AdjustJsonToDotNetFramework - handle null or empty strings (and also …

a697825

…throw meaningfull exception if failes)

nuget version

305901f

Fixed ObjectDisposedException during shutdown

3dd6fbd

updated nugets version

2a71724

Fixed ObjectDisposedException in tests

bfd7f48

ignroe OrleansSerialization_HttpRequestException_IsEquivalent until f…

cf49ab6

…ixed by Orleans

Use context.Response.Close instead of 'using' due to connection refus…

a6dab22

…ed issues

Added docker support for samples

4e317e1

nugets

b50d870

EranOfer commented Oct 16, 2019

View reviewed changes

EranOfer requested review from daniellm and yaronthurm October 16, 2019 09:00

EranOfer assigned yaronthurm and EranOfer Oct 16, 2019

Yaron Thurm and others added 11 commits October 24, 2019 10:57

Merge remote-tracking branch 'origin/develop' into getting_develop

ca4cd92

updated nuget version

13df9d3

Fixed test OneHostHasNetworkErrorShouldMoveToNextHost

eca5499

Moved AdjustJsonToDotNetFramework to SharedLogic and start using it i…

2dc9137

…n outgoing requests

Changed nuget version to 7.0.21-beta

71f4e86

AdjustJsonToDotNetFramework - On error return original text

0c40900

updated nugets to 7.0.23-beta

0a111d1

ServiceTester - Allocate disposeble port only if BasePortOverride is …

9bdc2b7

…not passed in

Solved issue with ProcessorAffinity in OSX

c24424c

Fix logic to determine OSX

f50e3cc

Fixed bug in ProcessorAffinityList

ff395c9

aikixd force-pushed the develop branch from 68ef31f to 49b82a0 Compare February 19, 2020 10:04

Updated PackageVersion to 7.0.23-beta

74d24af

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dot net standard #257

Dot net standard #257

EranOfer commented Oct 16, 2019

EranOfer Oct 16, 2019

EranOfer Oct 16, 2019

EranOfer Oct 16, 2019

EranOfer Oct 16, 2019

EranOfer Oct 16, 2019

aikixd Jan 9, 2020

EranOfer Oct 16, 2019

EranOfer Oct 16, 2019

EranOfer Oct 16, 2019

EranOfer Oct 16, 2019

EranOfer Oct 16, 2019

Dot net standard #257

Are you sure you want to change the base?

Dot net standard #257

Conversation

EranOfer commented Oct 16, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment