-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
small-and-fast: show bar graphs with <progress> and CSS #1894
Conversation
@To1ne do you have screenshots, too? Or are you deploying to https://To1ne.github.io/git-scm.com/? |
@dscho Screenshots added.
If only I knew how? |
This looks so awesome! And it is really clever to do that with CSS only!
Ah, I see, there is a failed deployment. That's because it tries to build it as a Jekyll site, which is the default on GitHub. Here is a complete set of steps how to deploy in your own fork (and yes, I should add this to the
The only thing I am unsure about is whether the current redirect from https://to1ne.github.io/ to https://iotcl.com/ would continue to work. It might require a new repository at https://github.com/to1ne/to1ne.github.io/ with a |
I had a look, and it does not seem as if So I looked and it seems that the What did work was to insert So maybe we should just forget about the tool-tip for now? Or do some Javascript trickery. |
Ah, that's the trickery you were doing? |
Yup 😏
Maybe this idea could work: Add the |
book.scss should only style inside the .book class.
Instead of relying on Google Graph or any other service to draw the graphs, draw them with pure HTML <progress> and some CSS. # Conflicts: # content/about/small-and-fast.html
@dscho I ditched the idea for having tooltips (for now) and cleaned up the code. What do you think, is this worth merging to get at least something shown on the page again? |
On https://github.com/To1ne/git-scm.com/settings/pages, do you see this? If "Deploy from a branch" is selected, then I understand the symptoms. If "GitHub Actions" is selected, I don't.
Thank you! I did play a little with the idea of pure-CSS progress bars, but thanks to
Yes, that sounds like the best idea. I will merge it. |
@dscho That has been bugging me in the past as well.
I don't think it's that bad. Actually, really nice work.
Well my solution also has that duplication, so that's not that bad. |
@To1ne FWIW I'm a bit out of time so I won't be playing with this for quite a while, just in case you wondered 😉 |
@dscho To be honest, I don't care enough to try to fix it further. But... it's broken on mobile: I think that's easily fixable with css grid. |
Instead of relying on Google Graph, or any other service to draw the
graphs, draw them with pure HTML and some CSS.
Fixes #1862.
Looks fairly decent on Firefox:
And Chromium:
I didn't get the tooltip working (fully) yet, if that's something we're looking for.