Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Index file present for both js and ts. #36

Open
Maanu07 opened this issue Dec 23, 2023 · 2 comments · May be fixed by #38
Open

Index file present for both js and ts. #36

Maanu07 opened this issue Dec 23, 2023 · 2 comments · May be fixed by #38

Comments

@Maanu07
Copy link
Contributor

Maanu07 commented Dec 23, 2023

I can see one index file in the src directory and the other in the root directory. I am not sure why we have an index.js file in the root directory. We can remove the index.js file. Let me know if I am missing something.
@DIVYESH-GITHUB
Copy link

@Maanu07 the index.js file was old code for the same. But now they have moved the logical code section into the src folder. And yes deleting the index.js file will not create any issue. I hope that helps.

@Maanu07
Copy link
Contributor Author

Maanu07 commented Dec 23, 2023

@Maanu07 the index.js file was old code for the same. But now they have moved the logical code section into the src folder. And yes deleting the index.js file will not create any issue. I hope that helps.

Cool, actually I added the index.ts file in the src directory but I also removed the index.js from the root directory. No idea how it came back. Maybe someone else PR introduced it again in the code.

This was referenced Dec 23, 2023
Open
Closed
@nishantsing nishantsing mentioned this issue Dec 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed index.js from root dir Maanu07/csv-to-sql-insert
2 participants
@Maanu07 @DIVYESH-GITHUB