index file remove from root and path change for createIfNot function #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devlopersabbir
suggested changes
Jan 1, 2024
|
Hi, checked the pull request, Is anything specific you want me to have a look at? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed [Issue #36 ]
Removed index.js file from the root because the project is transformed into TS structure and for a new contributor it will be easier to understand if we remove this non-essential file.
Fixed [Issue #61 ]
The createIfNot fn path parameter creates a dir "sql\ExampleTable.sql" and when we try to write the file it throws an error as it is a directory - Error: EISDIR: illegal operation on a directory
These issues were fixed as I saw but due to a bad merge, I can see them again which is a hindrance for a new contributor or user to run the app.