refactor: add json tags and improve error message #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This PR introduces several improvements and refactors to enhance code quality and maintainability:
Added JSON Tags:
Added
json
struct tags to theJWK
andJWKS
structs to ensure proper JSON serialization and deserialization. This improves compatibility with external APIs and ensures consistent JSON handling.Improved Error Messages:
Standardized error messages to follow Go conventions by removing capitalization and punctuation. This aligns with Go's idiomatic error handling practices.
Handled Unused Variables:
Replaced unused variables with
_
to explicitly indicate that they are intentionally ignored. This improves code readability and avoids linter warnings.Replaced Deprecated
io/ioutil
:Updated the code to use the
io
package instead of the deprecatedio/ioutil
package, as recommended in Go 1.16+. This ensures the codebase is up-to-date with modern Go practices.Fixed Typo:
Corrected the typo
"unsigendToken"
to"unsignedToken"
for better code clarity and accuracy.Why These Changes?
Impact:
Testing: