getPullRequestEditedDiffRanges: use GitHub API #2679
Merged
+675
−179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
cklin
force-pushed
the
cklin/get-diff-from-api
branch
from
59dd206 to
8fcc2ef
Compare
cklin
force-pushed
the
cklin/get-diff-from-api
branch
5 times, most recently
from
2f17622 to
2f35487
Compare
henrymercer
previously approved these changes
Jan 13, 2025
cklin
force-pushed
the
cklin/get-diff-from-api
branch
from
2f35487 to
82ea58e
Compare
cklin
force-pushed
the
cklin/get-diff-from-api
branch
from
82ea58e to
ae19466
Compare
|
@henrymercer I have addressed all comments; PTAL. I want to thank you especially for suggesting that I add tests, because one of those tests caught a bug (incorrect path separator on Windows). I have fixed the bug in the latest force push. |
henrymercer
approved these changes
Jan 14, 2025
Comment on lines
+768
to
+770
| export const exportedForTesting = { | ||
| getDiffRanges, | ||
| }; |
There was a problem hiding this comment.
I like this pattern, we should use it more in the rest of the Action :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
getPullRequestEditedDiffRangesso that it no longer obtains the PR diff through Git. Instead, it now obtains the PR diff through the GitHub Compare two commits API.