Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin: The 2.20.3 release supports Kotlin 2.1.10. #2744

Merged
merged 3 commits into from
Jan 29, 2025
Merged

Conversation

igfoo
Copy link
Contributor

@igfoo igfoo commented Jan 29, 2025

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@Copilot Copilot bot review requested due to automatic review settings January 29, 2025 12:58
@igfoo igfoo requested a review from a team as a code owner January 29, 2025 12:58

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

src/init-action.ts:547

  • The Kotlin version limit is set to 2.1.20, whereas the title suggests supporting Kotlin 2.1.10. Please confirm which version is correct to avoid confusion or unintended behavior.
core.exportVariable(kotlinLimitVar, "2.1.20");

src/init-action.ts:543

  • This new logic to set a Kotlin version limit depending on CodeQL versions is untested. Please add automated tests verifying that the environment variable is correctly set for CodeQL versions between 2.20.3 and 2.20.4.
if ( (await codeQlVersionAtLeast(codeql, "2.20.3")) && !(await codeQlVersionAtLeast(codeql, "2.20.4")) ) {

Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more

@igfoo igfoo merged commit a91a3f7 into main Jan 29, 2025
266 checks passed
@igfoo igfoo deleted the igfoo/kot2.1.10 branch January 29, 2025 16:45
@github-actions github-actions bot mentioned this pull request Jan 29, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants