Dependency version cleanup #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcreager
approved these changes
Mar 5, 2024
Comment on lines
-77
to
+78
| tree-sitter = ">= 0.19" | ||
| tree-sitter = "0.20" # keep the same minor version as the tree-sitter dependency | ||
| # of tree-sitter-graph to prevent install problems |
There was a problem hiding this comment.
This seems unfortunate, since it should all work with 0.19 as well. But it looks like several of the grammars have moved away from inclusive version constraints, so I guess this is the way 🤷 Maybe we can revert back to the inclusive constraint once tree-sitter/tree-sitter#3069 lands.
There was a problem hiding this comment.
I don't think this still worked, since tree-sitter-graph has a hard minimum of [email protected].
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweak the dependencies to prevent install problems such as those reported in #407.
The main change is to ensure that all
tree-sitterhave the same minor version, which prevents the Cargo resolver picking multiple versions for different crates.The underlying problem is that there seems to be no way to teel Cargo that two transitive dependencies of the same crate should be the same version. However, if types from that crate are part of the API, things break if values are passed from one to the other. So far, the only solution I've found is to ensure that if the minor versions are the same, the resolver will only pick one patch version, thus ensuring the same version is used everywhere. (For non-zero major versions it might be enough if the major version is the same?)
Main changes:
tree-sitterdependency versions to ensure they all use the same minor version.cargo hackto test all feature combinations.clifeature fortree-sitter-stack-graphs-javaso the CLI is not included by default anymore.lsp-positionsandtree-sitter-stack-graphs.