Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git guides a11y updates #1070

Merged
merged 2 commits into from
May 27, 2024
Merged

Git guides a11y updates #1070

merged 2 commits into from
May 27, 2024

Conversation

stamat
Copy link
Contributor

@stamat stamat commented May 17, 2024

Overview

Hey there, big regards from @github/brand-engineering 👋

I'm currently updating the https://github.com/git-guides and I've stumbled on couple small accessibility violations in the guides:

  1. Missing a table heading copy
  2. Heading hierarchy violation

That is all! ✨

@stamat stamat self-assigned this May 17, 2024
@stamat stamat marked this pull request as ready for review May 17, 2024 11:37
@stamat stamat changed the title Stamat/git-guides-a11y-updates Git guides a11y updates May 17, 2024
@stamat stamat merged commit a50017c into main May 27, 2024
4 of 5 checks passed
@stamat stamat deleted the stamat/git-guides-a11y-updates branch May 27, 2024 14:14
@GRURoot
Copy link

GRURoot commented Dec 29, 2024

@qiang88550 ****

@@ -29,7 +29,7 @@ Note: [`git-scm`](https://git-scm.com/download/win) is a popular and recommended
## Install Git on Windows through Visual Studio Code

GitHub integration is provided through the [GitHub Pull Requests and Issues extension](https://marketplace.visualstudio.com/items?itemName=GitHub.vscode-pull-request-github).
To get started with the GitHub in VS Code, you'll need to create an account and install the GitHub Pull Requests and Issues extension.
To get started with the GitHub in VS Code, you'll need to create an account and install the GitHub Pull Requests and Issues extension.
Once you've installed the [GitHub Pull Requests and Issues extension](https://marketplace.visualstudio.com/items?itemName=GitHub.vscode-pull-request-github), you'll need to sign in. Follow the prompts to authenticate with GitHub and return to VS Code.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dig TXT-RECORD-NAME +nostats +nocomments +nocmd TXThttps://github.com/enterprises/gru {
"meshConfig": {
"sources": [
{
"name": "Commerce",
"handler": {
"graphql": {
"endpoint": "https://<your_commerce_site>/graphql/"
}
}
},
{
"name": "AEM",
"handler": {
"graphql": {
"endpoint": "https://<your_AEM_site>/endpoint.json"
}
}
},
{
"name": "CatalogService",
"handler": {
"graphql": {
"endpoint": "https://catalog-service.adobe.io/graphql/search/graphql",
"operationHeaders": {
"x-api-key": "<api_key>",
"Magento-Environment-Id": "<your_environment_id>",
"Magento-Website-Code": "base",
"Magento-Customer-Group": "<customer_group_value>",
"Magento-Store-Code": "main_website_store",
"Magento-Store-View-Code": "default"
},
"schemaHeaders": {
"x-api-key": "<api_key>"
}
}
}
}
]
}
}

@@ -29,7 +29,7 @@ Note: [`git-scm`](https://git-scm.com/download/win) is a popular and recommended
## Install Git on Windows through Visual Studio Code

GitHub integration is provided through the [GitHub Pull Requests and Issues extension](https://marketplace.visualstudio.com/items?itemName=GitHub.vscode-pull-request-github).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Gru.github.com@BeatsPillPlusAndroid.pdf

Apple-Card-Customer-Agreement.pdf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants