Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify version for denoland/setup-deno #35

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

haphut
Copy link

@haphut haphut commented May 30, 2021

denoland/setup-deno@v1 was published recently and is used in the
README.md of the action:
https://github.com/denoland/setup-deno/blob/4a4e59637fa62bd6c086a216c7e4c5b457ea9e79/README.md

We should use it, too.

denoland/setup-deno@v1 was published recently and is used in the
README.md of the action:
https://github.com/denoland/setup-deno/blob/4a4e59637fa62bd6c086a216c7e4c5b457ea9e79/README.md

We should use it, too.
@irealva
Copy link
Contributor

irealva commented Jun 2, 2021

Note for team: we would have to update Deno versions in Flat Editor and demos if we merge this PR. And documentation.

@haphut
Copy link
Author

haphut commented Jun 2, 2021

Thanks for the response! I meant to make just a small improvement but I guess it's not that simple.

Currently the only difference between @main and @v1 seems to be the deno download URL. Do you mean that the team needs to update the setup-deno versions in Flat Editor and demos for consistency? EDIT: I assume you do: https://github.com/search?p=1&q=org%3Agithubocto+setup-deno&type=Code . That is a bit of work to fork all of those for a one-line change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants