-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding signal handler module #227
base: main
Are you sure you want to change the base?
Conversation
@nishith-vihar why are we defining signal handlers in every module ? Redant runs as a single process and signal handlers are to be defined on the process level. |
@srijan-sivakumar Ack. I think you are right . I checked it out again. I believe the signal handling has to be done in the main function of the redant alone. I will make the required changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A crude way. But a start nonetheless. The next stage is to add cleanups in individual test cases whenever they see this exception being raised. @nishith-vihar can you verify if this exception being raised is seen by the test runs too ? If it is the case, then we can do a cleanup directly in the except block in the parent_tests, else we have to come with a signalling mechanism within the main and the child processes ( which are running the TC ).
@aujjwal-redhat please review the code, I've removed the merge conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@nishith-vihar ...lint check.. |
Signal handler is added for the graceful exit of the test framework. Fixes: gluster#208 Signed-off-by: Nishith Vihar Sakinala <[email protected]>
Updates: gluster#58 Signed-off-by: Nishith Vihar Sakinala <[email protected]>
Signal handler function is added for graceful exiting of
the test framework.
Fixes: #208
Signed-off-by: Nishith Vihar Sakinala [email protected]