Skip to content

Commit

Permalink
Ports: Remove Clang -fPIC hack from zlib
Browse files Browse the repository at this point in the history
Despite the comment, only -fPIE was enabled by default in the Clang
toolchain, and not -fPIC. With the LLVM 14 upgrade, we made PIC the
default.
  • Loading branch information
BertalanD authored and bgianfo committed Apr 23, 2022
1 parent f1d47ea commit 8996161
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions Ports/zlib/package.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,6 @@ useconfigure=true
files="https://www.zlib.net/zlib-${version}.tar.gz zlib-${version}.tar.gz 91844808532e5ce316b3c010929493c0244f3d37593afd6de04f71821d5136d9"
auth_type="sha256"

pre_configure() {
# HACK: Even though Clang generates PIC objects by default, an R_386_PC32
# relocation still slips into libz.a if we don't set -fPIC explicitly.
export CFLAGS="-fPIC -O3"
}

configure() {
# Set uname to linux to prevent it finding the host's `libtool` on e.g. Darwin
run ./configure --uname=linux
Expand Down

0 comments on commit 8996161

Please sign in to comment.