Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #547: Modal Translations #571

Merged
merged 5 commits into from
Nov 21, 2018

Conversation

andre-meyer
Copy link
Contributor

Description

  • Implements Translations for all ModalContent components

Which Tickets does my PR fix? (Put in title too)

@andre-meyer andre-meyer requested a review from mmv08 November 20, 2018 10:25
@andre-meyer andre-meyer merged commit b48ee04 into development Nov 21, 2018
@andre-meyer andre-meyer deleted the feature/#547/modal-translations branch November 21, 2018 10:00
mmv08 added a commit that referenced this pull request Nov 21, 2018
* Deploy dist/embedded into /embedded

* Change public path for embedded

* embedded: Change browserrouter to hashrouter

* Feature #546: Header Translations (#562)

* wip translations

* finish header translations with subcomponents, reset default language

* remove language prop from i18n to be able to use queryparam

* fix missing css import

* fix css import

* fix embedding style

* Styles fix for embedded view

* Fix normalize.css import

* Feature #549: Marketlist Translations (#563)

* finish translations on marketlist page

* add en translations

* missing string in form

* hotfix: loading translation keys via webpack

* hotfix: font loading

* add dashboard translations

* hotfix: missing translation string

* finish market detail translation strings (#568)

* Merge master travis.yml

* remove autodll-webpack-plugin

* Modify management dev deployment for both interface and embedded

* Add staging embedded deployment specs

* Feature #547: Modal Translations (#571)

* finish legal modals, finish reward claim modals

* finish installmetamask modal, register wallet modal

* fix linting errors

* add switch network modal, add transaction explanation, unlock modal, verification error-modal, outcome price changed modal

* add proptype for t

* add max_old_space_size to build-prod

* Fix translations merge
mmv08 added a commit that referenced this pull request Nov 21, 2018
* Deploy dist/embedded into /embedded

* Change public path for embedded

* embedded: Change browserrouter to hashrouter

* Feature #546: Header Translations (#562)

* wip translations

* finish header translations with subcomponents, reset default language

* remove language prop from i18n to be able to use queryparam

* fix missing css import

* fix css import

* fix embedding style

* Styles fix for embedded view

* Fix normalize.css import

* Feature #549: Marketlist Translations (#563)

* finish translations on marketlist page

* add en translations

* missing string in form

* hotfix: loading translation keys via webpack

* hotfix: font loading

* add dashboard translations

* hotfix: missing translation string

* finish market detail translation strings (#568)

* Merge master travis.yml

* remove autodll-webpack-plugin

* Modify management dev deployment for both interface and embedded

* Add staging embedded deployment specs

* Feature #547: Modal Translations (#571)

* finish legal modals, finish reward claim modals

* finish installmetamask modal, register wallet modal

* fix linting errors

* add switch network modal, add transaction explanation, unlock modal, verification error-modal, outcome price changed modal

* add proptype for t

* add max_old_space_size to build-prod

* Fix translations merge

* Fix build-rpod command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants