Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #554: Misc. translations and footer #583

Merged
merged 2 commits into from
Dec 3, 2018

Conversation

andre-meyer
Copy link
Contributor

Description

  • Added new Footer Type: translation, takes a key that will be passed to the translations.

Which Tickets does my PR fix? (Put in title too)

Which PRs are linked to my PR?

  • /

Which side effects could my PR have?

  • The files that were previously used for the footer are no longer used in the current version

Which Steps did I take to verify my PR?

Markdown in Footer tested

  • Still works like before

Translations checked

  • Not in german though, to get them done

Background Information

  • /

Configuration Entries

/olympia/staging.config

{
  "footer": {
     ...
     "options: {
      "type": "translation",
      "key": "footer_tournament_md",
    }
  }
}

/mainnet/staging.config

{
  "footer": {
     ...
     "options: {
      "type": "translation",
      "key": "footer_md",
    }
  }
}

@andre-meyer andre-meyer requested a review from mmv08 November 30, 2018 09:59
@@ -1,15 +1,17 @@
import React from 'react'
imoprt PropTypes from 'prop-types'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... oops

@mmv08 mmv08 self-requested a review November 30, 2018 14:44
@andre-meyer andre-meyer merged commit 55dcda9 into development Dec 3, 2018
@andre-meyer andre-meyer deleted the feature/#554/misc-and-footer branch December 3, 2018 15:26
@andre-meyer andre-meyer restored the feature/#554/misc-and-footer branch June 21, 2019 08:47
@andre-meyer andre-meyer deleted the feature/#554/misc-and-footer branch June 21, 2019 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants