Deploy to BSC and Base Sepolia #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jfschwarz
commented
Nov 21, 2024
•
jfschwarz
commented
- support deployment with Frame
- include adapter contracts in deploy tasks
- deploy to BSC
- contracts
- subgraph
- deploy to Base Sepolia
- contracts
- subgraph
- update sdk and app
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jfschwarz
changed the title
juliopavila
reviewed
Nov 21, 2024
Comment on lines
+111
to
+115
| bsc: { | ||
| ...sharedNetworkConfig, | ||
| chainId: 56, | ||
| url: "https://bscrpc.com", | ||
| }, |
There was a problem hiding this comment.
@jfschwarz This change addresses an issue with the BSC network configuration where transactions fail due to underpriced gas with Roles.sol. Specifically, the error ProviderError: transaction underpriced: gas tip cap 1, minimum needed 1000000000 occurs because the gasPrice is not explicitly set.
To fix this, I added:
gasPrice: Number(parseUnits("1", "gwei")),
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.