Fix leak of weak references #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case where an object has been deallocated, fetching the old value of a weak reference to it returns nil. If we are assigning nil to the weak reference we can't abort processing early (when we check that old and new values are the same) as that will leave the weak reference in place when the calling code thinks it has destroyed it.
arc.mm
Outdated
| if (old == obj) | ||
| // If the old and new values are the same, then we don't need to do anything | ||
| // unless we are deleting the weak reference by storing NULL to it. | ||
| if (old == obj && (obj != NULL || NULL == oldRef)) |
There was a problem hiding this comment.
Please can you add some brackets around this? I am not sure what the precedenc e is between || and == without looking it up and the next person reading the code might not either.
Clarify standard operator precedence
davidchisnall
approved these changes
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case where an object has been deallocated, fetching the old value of a weak reference to it returns nil. If we are assigning nil to the weak reference we can't abort processing early (when we check that old and new values are the same) as that will leave the weak reference in place when the calling code thinks it has destroyed it.