New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added eslint and mocha test. #9

Open

justin-lau wants to merge 1 commit into gobblejs:master from justin-lau:lint-and-test

justin-lau commented Oct 31, 2015

This PR does two things:

Added linting to the package to maintain a persistent coding style. The eslint config is copied from gobble core. The concat() function is removed from index.js because it isn't used anywhere.
Added basic structure for testing with mocha. I also added a simple test case that currently fails due to Require fails at runtime with "Cannot find module ..' #6.

I try to stick with the coding style and file structure used by @Rich-Harris as much as possible, but the eslint rule doesn't check everything.


          Added eslint and mocha test.

eb0d24c

justin-lau force-pushed the lint-and-test branch from cc879a1 to eb0d24c Compare

October 31, 2015 15:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet