-
Notifications
You must be signed in to change notification settings - Fork 24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding Github Action!
Also, sorting them on the option is nice. (just one of my habits, I usually make a separate commit for easy reading for changed things on another commit but yours also fine :-)
I added some comments about unnecessary changes in the test code and an outdated command. Please fix them and I will proceed the next step.
This reverts commit 0f3b778.
Thanks a lot for your quick review! Let me know if I can do something else. |
@VictorBersy please do not push an empty commit. |
Sorry I don't think I can restart failing jobs :( Won't it be squashed anyway at the merge? |
Yeah, will do. anyway, if I found a failed test, I still have a chance to check if the failure is ignorable or just run the failed one manually without spending the whole test hours. also, I need to check/review what is on the (empty) commit. :-) |
Oh right I see 🙇 It's my first real OSS contributions so I'm still figuring out things 🫣 |
NOTE: failed test is not an issue with the PR but the timeout. (need to check if we can reduce the testing time)
|
I roughly don't think this PR introduced the test failure but I would like to check the fix manually. Please wait until the test is completed. |
I tested the failed test case (actually along with all others) in my local environment (ubuntu 20.04 + go1.17.8) and the result was fine. I will merge it into the development branch now and will check if the test fails again. Interestingly, the other PRs (dependabot's PRs) just succeeded on the same tests always 🤔 |
Interesting, I will try to see if I can help with #200 then. Glad I could contribute, thanks a lot for your patience and review 🙇 |
Thank you for your contribution and your patience during waiting for a long review. I wanted to make it sure the change is totally compatible with the code base and also it could be a chance to find/fix another (unrelated) bug on the code or testing.
I think there should be some strategic decision inside the team, and since there is another progress updating plugin architecture which is a big thing and not fully compatible with the current code base, I think the issue would be addressed once we have a new codebase and having discussion. |
While playing with Bufallo, I noticed Github Actions was not supported out-of-the box. This PR aims to solve this by adding a standard GHA template.
I've sorted the
ci-provider
alphabetically, along the tests, so it's easier to spot what we are looking for.I haven't had the chance yet to test the template itself.
I'm fairly new to Golang so I might have missed a few things, let me know.