Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to github actions #221

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kritika-singh3
Copy link
Contributor

  • testing the PR build
  • testing and releasing an exp version of the jar via Java 15
  • making a stable release

Also updated the plugin version nd the min GoCD version to 20.9.0

@kritika-singh3 kritika-singh3 marked this pull request as draft November 18, 2020 04:24
@chadlwilson
Copy link
Contributor

chadlwilson commented Jan 27, 2022

Do you remember what was required to get this last plugin pipeline complete @kritika-singh3 ? Was it the complication of also having to push the dsl jar into Maven Central which is a bit different to the other plugins?

@kritika-singh3
Copy link
Contributor Author

Yes @chadlwilson - we publish the jar as well to Maven central. The question at that time was r we going to continue the same or not. Hence, this PR was left at draft.

@chadlwilson
Copy link
Contributor

OK, thanks! I assumed it was that. I was trying to do a Gradle upgrade to 7 but got stuck needing to use different plugins to push to Maven Central and not really having a way to validate/test it. Hmm :-)

@kritika-singh3
Copy link
Contributor Author

hmm maybe you can skip that part for now (create an issue/discussion for later) & move on with Gradle update?

@chadlwilson
Copy link
Contributor

I thought that would make the plugin un-releaseable if we can't push to Maven Central, and so might be a bad idea? Although I guess the DSL doesn't really change that often now (my last PR does change it slightly though).

Anyway, the Gradle upgrade isn't of huge value so not a huge problem if that doesn't happen for a while.

 - testing the PR build
 - testing and releasing an exp version of the jar via Java 17
 - making a stable release
@chadlwilson chadlwilson force-pushed the update-to-github-actions branch from 0b21a4a to 08823ba Compare February 10, 2022 15:15
Still need to figure out the best way to get the GPG key/passphrase into the action and safely to the Maven Signing plugin.
https://docs.gradle.org/current/userguide/signing_plugin.html#sec:using_gpg_agent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants