-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to the latest Kubernetes Client #348
Conversation
This property has been removed in the latest versions of the k8s spec and has always been unsettable and defaulted to a blank string. See: https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.24.md#deprecation:~:text=%40knight42)-,The%20metadata.clusterName%20field%20is%20deprecated.%20This%20field%20has%20always%20been,are%20found%20before%20complete%20removal.%20(%23108717%2C%20%40lavalamp),-VSphere%20releases%20less This field is also not used by the plugin.
kubernetes-client `5.12.4` -> `6.5.1`
Directly using `new DefaultKubernetesClient` is deprecated in favour of the builder.
Thanks for this, will take a look. I'd been meaning to take a look at the client upgrade (I'd already done it on the sister kubernetes-secrets plugin but there was something in the changelog here that concerned me for some reason. Will take a look at your changes and try and recollect 😅 |
a58fa25
to
1460bd6
Compare
Thanks, made a couple of minor tweaks, but this seems to be working fine. |
Thanks very much @chadlwilson! |
FYI, the underlying bug in the client with auto config and automatic token refresh is fixed now, and I've intentionally re-enabled this to reduce config needs of the plugin in many cases in #386 - should have no effect on most folks, but if you want to give it a go it'd be appreciated. |
Hey Chad, thanks for the heads up, sure we can give it a go shortly 👍 |
If youre interested in how they fixed the underlying bug you worked around, they introduced |
I can confirm that kubernetes-elastic-agent |
Upgrade to the latest version of the kubernetes-client library and disable auto configuration.
Fixes: #347