Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to the latest Kubernetes Client #348

Merged
merged 9 commits into from
Apr 23, 2023

Conversation

JamesMcNee
Copy link

Upgrade to the latest version of the kubernetes-client library and disable auto configuration.

Fixes: #347

@JamesMcNee JamesMcNee changed the title Kubernetes client 620 Upgrade to the latest Kubernetes Client Apr 18, 2023
@chadlwilson
Copy link
Member

Thanks for this, will take a look. I'd been meaning to take a look at the client upgrade (I'd already done it on the sister kubernetes-secrets plugin but there was something in the changelog here that concerned me for some reason. Will take a look at your changes and try and recollect 😅

@chadlwilson chadlwilson force-pushed the kubernetes-client-620 branch from a58fa25 to 1460bd6 Compare April 23, 2023 07:37
@chadlwilson
Copy link
Member

Thanks, made a couple of minor tweaks, but this seems to be working fine.

@chadlwilson chadlwilson merged commit 7f9939f into gocd:master Apr 23, 2023
@chadlwilson
Copy link
Member

@JamesMcNee JamesMcNee deleted the kubernetes-client-620 branch April 23, 2023 08:34
@JamesMcNee
Copy link
Author

Thanks very much @chadlwilson!

@chadlwilson
Copy link
Member

chadlwilson commented Jan 8, 2024

FYI, the underlying bug in the client with auto config and automatic token refresh is fixed now, and I've intentionally re-enabled this to reduce config needs of the plugin in many cases in #386 - should have no effect on most folks, but if you want to give it a go it'd be appreciated.

@JamesMcNee
Copy link
Author

Hey Chad, thanks for the heads up, sure we can give it a go shortly 👍

@chadlwilson
Copy link
Member

If youre interested in how they fixed the underlying bug you worked around, they introduced autoOauthToken independent of oauthToken so that any autorefeshed token from a provider or auto configuration would never be able to override a hard set token from the user.

@chris-gillatt
Copy link

FYI, the underlying bug in the client with auto config and automatic token refresh is fixed now, and I've intentionally re-enabled this to reduce config needs of the plugin in many cases in #386 - should have no effect on most folks, but if you want to give it a go it'd be appreciated.

I can confirm that kubernetes-elastic-agent 4.0.0-505 works well with no credential issues on GoCD 23.5.0. Thanks all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect credentials being used when creating Kubernetes Client
3 participants