Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Beyond #100000: You're breathtaking!" #972

Merged

Conversation

adamscott
Copy link
Member

@adamscott adamscott commented Dec 4, 2024

Add a copy of godotengine/godot#100000 to the blog, including some CSS fixes.

Screenshot 2024-12-04 at 13-08-23 Beyond #100000 You're breathtaking! – Godot Engine webp

@adamscott adamscott mentioned this pull request Dec 4, 2024
@hpvb
Copy link
Member

hpvb commented Dec 4, 2024

This is great! Can we add the images etc to our own hosting? I'm not sure if github user content links are entirely stable.

@coppolaemilio
Copy link
Member

I don't think we can use Keanu's picture here, I would replace it with something else. The share image generated by Github, or a picture of the repository @adamscott

@adamscott adamscott force-pushed the youre-breathtaking-rémi branch from dfc0d6e to 6e5cf8e Compare December 4, 2024 17:20
@adamscott
Copy link
Member Author

This is great! Can we add the images etc to our own hosting? I'm not sure if github user content links are entirely stable.

Done! I reduced the crap out of the gifs and the pngs also.

I don't think we can use Keanu's picture here, I would replace it with something else. The share image generated by Github, or a picture of the repository @adamscott

I'll do.

@adamscott adamscott force-pushed the youre-breathtaking-rémi branch 3 times, most recently from 7ed3579 to e81a313 Compare December 4, 2024 18:08
@adamscott
Copy link
Member Author

adamscott commented Dec 4, 2024

Replaced the real photo by this:

beyond-100000-you-re-breathaking webp

(I'm the author of the sketch)

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

author: "Rémi Verschelde"
image: /storage/blog/covers/beyond-100000-you-re-breathaking.webp
image_caption_title: "\"You're breathtaking!\""
image_caption_description: "Sketch of Keanu Reeves at the 2019 #XboxE3 event"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you really telling me this was 5 whole years ago?! 👴

collections/_article/beyond-100000-you-re-breathaking.md Outdated Show resolved Hide resolved
collections/_article/beyond-100000-you-re-breathaking.md Outdated Show resolved Hide resolved

To deal with it, we need better triage and review processes (which we are designing now), more volunteers involved in these processes, but also importantly [**more funding**](https://fund.godotengine.org/). Volunteer contributors do a ton of work, but many critical parts of the workflow depend on a few paid contractors, and we need to grow that group to better manage the increasing scale of the project.

[^1]: I'll make a quick note that 100,000 is the combined number of issues and PRs, which share the same index system on GitHub.<br><br>At the time of writing, we've actually had 53,648 issues and 45,213 PRs created. Astute minds will notice that the sum is not 100,000, the difference comes from spam issues or PRs which have been deleted by GitHub.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm amazed to see this feature works in Jekyll markdown too :D

@adamscott adamscott force-pushed the youre-breathtaking-rémi branch from e81a313 to 5764d82 Compare December 4, 2024 18:45
@akien-mga akien-mga added the topic:blog New blogposts and corrections label Dec 4, 2024
@@ -0,0 +1,100 @@
---
title: "Beyond #100000: You're breathtaking!"
excerpt: "As we reach issue #100000 on GitHub, we celebrate with a little retrospective on our issue and PR growth."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
excerpt: "As we reach issue #100000 on GitHub, we celebrate with a little retrospective on our issue and PR growth."
excerpt: "As we reach issue 100,000 on GitHub, we celebrate with a little retrospective on our issue and PR growth."

Copy link
Member Author

@adamscott adamscott Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, as it's issue #(number) 100000, isn't it? Maybe #100,000?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe. For some reason, I just thought the # looked out of place in the excerpt, even though it's common syntax in GitHub comments etc. I don't really mind either way though.

collections/_article/beyond-100000-you-re-breathtaking.md Outdated Show resolved Hide resolved
collections/_article/beyond-100000-you-re-breathtaking.md Outdated Show resolved Hide resolved
collections/_article/beyond-100000-you-re-breathtaking.md Outdated Show resolved Hide resolved
collections/_article/beyond-100000-you-re-breathtaking.md Outdated Show resolved Hide resolved
@JohnVeness
Copy link
Collaborator

This is great! Can we add the images etc to our own hosting? I'm not sure if github user content links are entirely stable.

Done! I reduced the crap out of the gifs and the pngs also.

Looks like there's still a couple as GitHub user-attachments...

@adamscott adamscott force-pushed the youre-breathtaking-rémi branch 2 times, most recently from 2175265 to fe70cf3 Compare December 4, 2024 20:06
@adamscott
Copy link
Member Author

Looks like there's still a couple as GitHub user-attachments...

Thanks @JohnVeness! I fixed it.

@adamscott adamscott force-pushed the youre-breathtaking-rémi branch from fe70cf3 to 40f2626 Compare December 4, 2024 20:28
@coppolaemilio coppolaemilio merged commit 151966e into godotengine:master Dec 4, 2024
1 check passed
@coppolaemilio
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic:blog New blogposts and corrections
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants