Set non-empty default mount options for the backup_mount
resource.
#34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
backup_mount
resource passes an array ofnode['backup']['mount_options']
to the underlying mount resource since #27. Since these mount options are empty by default and they are passed verbatim to the underlying mount resource, not specifying any mount options explicitly results in broken entries in/etc/fstab
.For example:
Note that each chef-run adds a line to the /etc/fstab file.
When the server restarts, the backup directory will not be mounted until the next chef-run.
This PR adds default, safe options (
default['backup']['mount_options'] = ['soft', 'nosuid']
) which should work out of the box.