Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch from openai to gemini #98

Closed
wants to merge 1 commit into from
Closed

Conversation

satvik314
Copy link

Added notebook guide to use Gemini API with full OpenAI compatibility using Portkey.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@markmcd markmcd added the status:awaiting response Awaiting a response from the author label Sep 11, 2024
@markmcd
Copy link
Member

markmcd commented Sep 11, 2024

Thanks for the contribution. Before we do a deep review, we have a few questions about the content. It might be easier to create a new issue where we can work out what guides to include and what they look like.

My initial questions are:

  • Is it possible to run the Portkey system locally instead of using a remote service? This way users can try it out without giving their API key to a third party.
    • If not, would you mind if we put a warning on the part where they share their API key?
  • Can you provide some stats on the platform's popularity? See our contrib guide, but we are only accepting contributions for widely adopted platforms, with some exceptions for technical novelty. Public numbers are fine.
  • Can you ensure the guide is focused on a single topic (e.g. "using a compatible interface" is one topic, "observability with portkey" is another)
    • Focused content is more useful to users, and it will help us review each guide on its own merits.

We also have a template you can use now, it includes some authoring guidelines. And you'll need to rebase your change to HEAD so you pick up the latest GH actions.

Copy link

Marking this pull request as stale since it has been open for 14 days with no activity. This PR will be closed if no further activity occurs.

@github-actions github-actions bot added the status:stale Issue/PR is marked for closure due to inactivity label Sep 25, 2024
Copy link

github-actions bot commented Oct 8, 2024

This pull request was closed because it has been inactive for 27 days. Please open a new pull request if you need further assistance. Thanks!

@github-actions github-actions bot closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:awaiting response Awaiting a response from the author status:stale Issue/PR is marked for closure due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants