Request the minimum of limit and batch_size. #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vilasj
reviewed
Jun 15, 2017
apitools/base/py/list_pager.py
Outdated
| setattr(request, current_token_attribute, None) | ||
| while limit is None or limit: | ||
| if batch_size_attribute: | ||
| request_batch_size = min(batch_size, |
There was a problem hiding this comment.
request_batch_size = min(batch_size, limit or batch_size) ?
This prevents YieldFromList from requesting more resources than originally requested by the caller.
|
The server side only receives a single "page_size". In the case of our API, we just noticed this due to some bad test data further down in the list. For some APIs, List costs money per result returned, so I believe this is good in general. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #164 by setting the batch_size on each request to the min of the limit and the batch_size.