[Annotation Only] Adding case insensitive to enum based on loading JsonEnum config #1323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matanshukry
commented
May 20, 2023
| this.defaultValue, | ||
| this.disallowNullValue, | ||
| this.fromJson, | ||
| @Deprecated( | ||
| 'Use `includeFromJson` and `includeToJson` with a value of `false` ' | ||
| 'instead.', | ||
| ) | ||
| this.ignore, | ||
| this.ignore, |
There was a problem hiding this comment.
fyi this was done by dart format 🤷
There was a problem hiding this comment.
You need to be using a dev release of Dart 3.1 for this.
t-beckmann
reviewed
May 21, 2023
| /// Specifically, both values will be lower-cased and compared. | ||
| /// | ||
| /// Valid only on enum fields with a compatible enum value. | ||
| final bool caseInsensitive; |
There was a problem hiding this comment.
Why is the option needed on both JsonEnum and JsonKey?
There was a problem hiding this comment.
@t-beckmann so it can be used both at the enum level and at the field level.
Your question did make me add tests to the original PR, so I also found an issue and fixed it, and added 3 test cases: case insensitive on enum level, case insensitive on field level, and without any case insensitive (verifying behavior is same without it).
Example from the other PR:
- On the enum: https://github.com/google/json_serializable.dart/pull/1155/files#diff-1ac6a89c51c26fa87981cde2ede9cfa268021350a1bdc2770e982feea1dcf242R9
- On the field: https://github.com/google/json_serializable.dart/pull/1155/files#diff-976667989c3ddcc9bb6d6470103769f5aa9c376f142a64c76fadb4b52f03b736R58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1155 - see details here.
This is just the annotation part of the PR.