Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bool? casted to bool. #1444

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix bool? casted to bool. #1444

wants to merge 1 commit into from

Conversation

qwe321
Copy link

@qwe321 qwe321 commented Aug 14, 2024

Question mark was missing in case of optional bool field.

Copy link

google-cla bot commented Aug 14, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@kevmoo
Copy link
Collaborator

kevmoo commented Aug 14, 2024

We'll really want test coverage here!

@kevmoo
Copy link
Collaborator

kevmoo commented Jan 2, 2025

Need the CLA signed and please add a test!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants