Add RPC logging.

PiperOrigin-RevId: 686667172
google · Oct 16, 2024 · b52f297 · b52f297
1 parent 2183467
commit b52f297
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 6 deletions.
diff --git a/sharing/analytics/analytics_recorder.h b/sharing/analytics/analytics_recorder.h
@@ -198,7 +198,7 @@ class AnalyticsRecorder {
 
   void NewRpcCallStatus(
       absl::string_view rpc_name,
-      nearby::sharing::analytics::proto::SharingLog::RpcCallStatus::RpcDirection
+      nearby::sharing::analytics::proto::SharingLog_RpcCallStatus::RpcDirection
           direction,
       int error_code, absl::Duration latency);
 

diff --git a/sharing/internal/api/sharing_platform.h b/sharing/internal/api/sharing_platform.h
@@ -20,8 +20,8 @@
 #include <memory>
 #include <vector>
 
-#include "absl/status/status.h"
 #include "absl/strings/string_view.h"
+#include "internal/platform/clock.h"
 #include "internal/platform/device_info.h"
 #include "internal/platform/implementation/account_manager.h"
 #include "internal/platform/task_runner.h"
@@ -85,7 +85,8 @@ class SharingPlatform {
 
   virtual std::unique_ptr<SharingRpcClientFactory>
   CreateSharingRpcClientFactory(
-      nearby::sharing::analytics::AnalyticsRecorder* analytics_recorder) = 0;
+      nearby::sharing::analytics::AnalyticsRecorder* analytics_recorder,
+      Clock* clock) = 0;
 
   // On platforms where it is supported, tag the transferred files as
   // originating from an untrusted source.

diff --git a/sharing/nearby_sharing_service.h b/sharing/nearby_sharing_service.h
@@ -22,14 +22,13 @@
 
 #include "absl/base/attributes.h"
 #include "absl/functional/any_invocable.h"
-#include "absl/strings/string_view.h"
 #include "absl/time/time.h"
+#include "internal/platform/clock.h"
 #include "sharing/advertisement.h"
 #include "sharing/attachment_container.h"
 #include "sharing/internal/api/sharing_rpc_notifier.h"
 #include "sharing/local_device_data/nearby_share_local_device_data_manager.h"
 #include "sharing/nearby_sharing_settings.h"
-#include "sharing/share_target.h"
 #include "sharing/share_target_discovered_callback.h"
 #include "sharing/transfer_update_callback.h"
 
@@ -255,6 +254,7 @@ class NearbySharingService {
   virtual NearbyShareContactManager* GetContactManager() = 0;
   virtual NearbyShareCertificateManager* GetCertificateManager() = 0;
   virtual AccountManager* GetAccountManager() = 0;
+  virtual Clock& GetClock() = 0;
 };
 
 }  // namespace sharing

diff --git a/sharing/nearby_sharing_service_impl.cc b/sharing/nearby_sharing_service_impl.cc
@@ -201,7 +201,8 @@ NearbySharingServiceImpl::NearbySharingServiceImpl(
       analytics_recorder_(*analytics_recorder),
       nearby_connections_manager_(std::move(nearby_connections_manager)),
       nearby_share_client_factory_(
-          sharing_platform.CreateSharingRpcClientFactory(&analytics_recorder_)),
+          sharing_platform.CreateSharingRpcClientFactory(&analytics_recorder_,
+                                                         context_->GetClock())),
       profile_info_provider_(
           std::make_unique<NearbyShareProfileInfoProviderImpl>(
               device_info_, account_manager_)),

diff --git a/sharing/nearby_sharing_service_impl.h b/sharing/nearby_sharing_service_impl.h
@@ -35,6 +35,7 @@
 #include "absl/time/time.h"
 #include "absl/types/span.h"
 #include "internal/base/observer_list.h"
+#include "internal/platform/clock.h"
 #include "internal/platform/device_info.h"
 #include "internal/platform/implementation/account_manager.h"
 #include "internal/platform/task_runner.h"
@@ -171,6 +172,7 @@ class NearbySharingServiceImpl
   NearbyShareContactManager* GetContactManager() override;
   NearbyShareCertificateManager* GetCertificateManager() override;
   AccountManager* GetAccountManager() override;
+  Clock& GetClock() override { return *context_->GetClock(); }
 
   // NearbyConnectionsManager::IncomingConnectionListener:
   void OnIncomingConnection(absl::string_view endpoint_id,