jackson-dataformats-binary: Fix looping condition #11376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Chan <[email protected]>
|
arthurscchan (verified) is either the primary contact or is in the CCs list of projects/jackson-dataformats-binary. |
AdamKorcz
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Java, modulo operations are done with absolute value first, then the negative sign will be added to the modulo result if either of the left or right operands is negative. Thus if the choice is negative, the modulo result will always be negative and it automatically goes to the default branch for all the fuzzers. This makes the choice very unbalance and there are less than half chances to execute the other 18 branches. This PR fixes the bias problem by taking the absolute value of the integer choice before the modulo operation to ensure the result must be 0~18 inclusively.