Fastify: fix dockerfile to downgrade nodejs to version 19.2 #11390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
arthurscchan (verified) is either the primary contact or is in the CCs list of projects/fastify. |
Signed-off-by: Arthur Chan <[email protected]>
arthurscchan
force-pushed
the
fix-dockerfile-npm-version
branch
from
172d038 to
8661820
Compare
arthurscchan
changed the title
AdamKorcz
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the Dockerfile for project fastify by switching the default nodejs version to 19.2 to avoid a strange failing of npm build in Docker as mentioned in nodejs/docker-node#1912.