Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSoC Adding retriever into OSS Fuzz #12066

Closed
wants to merge 3 commits into from

Conversation

PatriceJada
Copy link

Main Maintainer @henrykironde

Copy link

PatriceJada is integrating a new project:
- Main repo: https://github.com/weecology/retriever
- Criticality score: 0.55757

@jonathanmetzman
Copy link
Contributor

jonathanmetzman commented Jun 14, 2024

Do you have a link to the GSoC project you are working on?
Also, could we try to integrate the projects one at a time? It's a lot to integrate ~10 projects.

@PatriceJada
Copy link
Author

@jonathanmetzman This is the link to the GSoC page https://github.com/numfocus/gsoc/wiki/GSoC-2024-GOSST and this is the issue numfocus/gsoc#470

@jonathanmetzman
Copy link
Contributor

Does the main maintainer approve?

@jonathanmetzman
Copy link
Contributor

How about you keep open these PRs and the first projects you make progress on, I'll merge those PRs.

@henrykironde
Copy link

@jonathanmetzman , I approve.

@PatriceJada
Copy link
Author

How about you keep open these PRs and the first projects you make progress on, I'll merge those PRs.

@jonathanmetzman Correct me if I'm wrong but my understanding was that for the project to be accepted we need to follow these steps https://google.github.io/oss-fuzz/getting-started/accepting-new-projects/. Then once the project is merged we move to these steps https://google.github.io/oss-fuzz/getting-started/new-project-guide/

@jonathanmetzman
Copy link
Contributor

How about you keep open these PRs and the first projects you make progress on, I'll merge those PRs.

@jonathanmetzman Correct me if I'm wrong but my understanding was that for the project to be accepted we need to follow these steps https://google.github.io/oss-fuzz/getting-started/accepting-new-projects/. Then once the project is merged we move to these steps https://google.github.io/oss-fuzz/getting-started/new-project-guide/

That is the correct procedure, but to be honest, no one else has tried to integrate ~10 projects at once.
For each project someone tries to add to oss-fuzz, we need to discuss whether to accept it.
This is potentially a lot of work for us. I'd rather you integrate projects one at a time so we don't spend time discussing project integrations that don't get completed.
Also, doing integrations one at a time would make it easier to incorporate feedback. For example, I think the "MSAN" option doesn't make sense here, and you should also say why the project is important and/or critical infra.

PatriceJada added a commit to PatriceJada/oss-fuzz that referenced this pull request Aug 6, 2024
@DonggeLiu
Copy link
Contributor

How about you keep open these PRs and the first projects you make progress on, I'll merge those PRs.

@jonathanmetzman Correct me if I'm wrong but my understanding was that for the project to be accepted we need to follow these steps https://google.github.io/oss-fuzz/getting-started/accepting-new-projects/. Then once the project is merged we move to these steps https://google.github.io/oss-fuzz/getting-started/new-project-guide/

That is the correct procedure, but to be honest, no one else has tried to integrate ~10 projects at once. For each project someone tries to add to oss-fuzz, we need to discuss whether to accept it. This is potentially a lot of work for us. I'd rather you integrate projects one at a time so we don't spend time discussing project integrations that don't get completed. Also, doing integrations one at a time would make it easier to incorporate feedback. For example, I think the "MSAN" option doesn't make sense here, and you should also say why the project is important and/or critical infra.

Rejecting the following PRs (including this PR) accordingly:

@DonggeLiu DonggeLiu closed this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants