Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable fuzzers for feature branches ml-kem and quic-server #13017

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sashan
Copy link
Contributor

@Sashan Sashan commented Feb 7, 2025

We need to enable fuzzing of feature branches before they will get merge to master.

Copy link

github-actions bot commented Feb 7, 2025

Sashan has previously contributed to projects/openssl. The previous PR was #12117

Copy link
Contributor

@vdukhovni vdukhovni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the CI failures expected?

@@ -21,6 +21,8 @@ RUN cd $SRC/openssl/ && git submodule update --init fuzz/corpora
RUN git clone --depth 1 --branch openssl-3.0 https://github.com/openssl/openssl.git openssl30
RUN git clone --depth 1 --branch openssl-3.1 https://github.com/openssl/openssl.git openssl31
RUN git clone --depth 1 --branch openssl-3.2 https://github.com/openssl/openssl.git openssl32
RUN git clone --depth 1 --branch feature/ml-kem https://github.com/openssl/openssl.git openssl-ml-kem
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also feature/ml-dsa, unless the fuzzer for it is not yet ready.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm investigating failures. will update the request once I'll figure out what's going on.

@kroeckx
Copy link
Contributor

kroeckx commented Feb 18, 2025

This is no longer needed I guess?

@vdukhovni
Copy link
Contributor

This is no longer needed I guess?

Indeed, with the feature branch merged, this is now moot.

Copy link
Contributor

@vdukhovni vdukhovni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should now close this PR, the feature branches are going away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants