-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable fuzzers for feature branches ml-kem and quic-server #13017
base: master
Are you sure you want to change the base?
Conversation
Sashan has previously contributed to projects/openssl. The previous PR was #12117 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the CI failures expected?
@@ -21,6 +21,8 @@ RUN cd $SRC/openssl/ && git submodule update --init fuzz/corpora | |||
RUN git clone --depth 1 --branch openssl-3.0 https://github.com/openssl/openssl.git openssl30 | |||
RUN git clone --depth 1 --branch openssl-3.1 https://github.com/openssl/openssl.git openssl31 | |||
RUN git clone --depth 1 --branch openssl-3.2 https://github.com/openssl/openssl.git openssl32 | |||
RUN git clone --depth 1 --branch feature/ml-kem https://github.com/openssl/openssl.git openssl-ml-kem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also feature/ml-dsa
, unless the fuzzer for it is not yet ready.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm investigating failures. will update the request once I'll figure out what's going on.
This is no longer needed I guess? |
Indeed, with the feature branch merged, this is now moot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should now close this PR, the feature branches are going away.
We need to enable fuzzing of feature branches before they will get merge to master.