gnutls: Fix build #13032
Merged
gnutls: Fix build #13032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a build failure for GNUTLS caused by GNUTLS requiring a minimum version of autoconf 2.71 but the fuzzer base image is Ubuntu 20 based which has 2.6x. Also fix some shellcheck identified warnings related to unquoted path variables.
Fix build failure caused by libtasn1 (a dependency of gnutls) bootstrap process that sets the gnulib git checkout to a specific commit ID. The commit ID must be present in the local checkout to succeed otherwise an error like "fatal: reference is not a tree: <commit hash ID>". A depth of 500 was chosen as a compromise to make it likely that the commit will be present as long as libtasn1 pulls in a fairly recent version and cloning the whole gnulib repo which is quite large.
|
hiowaguy is a new contributor to projects/gnutls. The PR must be approved by known contributors before it can be merged. The past contributors are: maflcko, ueno, DonggeLiu, Navidem, nmav, devtty1er, Dor1s, rockdaboot (unverified) |
|
@ueno - Hello, are you able to review this change please? |
|
cc @DavidKorczynski for approval |
DavidKorczynski
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gnutls: Fix build failure related to gnulib specific commit reference
Fix build failure caused by libtasn1 (a dependency of gnutls) bootstrap process that sets the gnulib git checkout to a specific commit ID. The commit ID must be present in the local checkout to succeed otherwise an error like "fatal: reference is not a tree: ". A depth of 500 was chosen as a compromise to make it likely that the commit will be present as long as libtasn1 pulls in a fairly recent version and cloning the whole gnulib repo which is quite large.
gnutls: Fix build failure due to newer required autoconf and cleanup
Fix a build failure for GNUTLS caused by GNUTLS requiring a minimum version of autoconf 2.71 but the fuzzer base image is Ubuntu 20 based which has 2.6x. Also fix some shellcheck identified warnings related to unquoted path variables.