fix: add new logo in report #1562
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.Added a global variable servePort with a default value of "8000" 2.Added a new CLI flag --port that allows users to customize the port number used when serving the HTML report 3. Removed the hardcoded port number from the ServeHTML function, using the global servePort variable instead 4. The flag's Action function updates the global servePort variable when a custom port is specified These changes allow users to specify a custom port using the --port flag when using the --serve option, while maintaining the default port 8000 if no custom port is specified.
…xed_issue_#1555 fixed issue google#1555
feature: add a new string flag to help the user specify a server port instead of just using a hard coded value
jess-lowe
reviewed
Feb 3, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1562 +/- ##
=======================================
Coverage 69.29% 69.29%
=======================================
Files 200 200
Lines 19038 19038
=======================================
Hits 13193 13193
Misses 5137 5137
Partials 708 708 ☔ View full report in Codecov by Sentry. |
… that the linter test passes
…imaan-Senapati/osv-scanner into fix_add_new_logo_in_report
jess-lowe
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: added new logo in report_template.gohtml line 18 with
docs/images/osv-scanner-OSV-logo-darkmode.pngas outlined in issue #1554 by @jess-lowe and @hogo6002