Support GHC up to 9.6 and add CI for them all #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump up some bounds on base which should make this a safe change on older ghc versions.
|
I'll remove the top commit once we merge google/ghc-source-gen#107 and release it to hackage. |
|
@ysangkok thanks for pointing out the missing pieces. I think I got them all. If you care to take another look, I can wait and release after that. |
|
Somebody should push the "approve" button too. |
ysangkok
approved these changes
Dec 23, 2023
ysangkok
reviewed
Dec 23, 2023
ysangkok
reviewed
Dec 23, 2023
GHC started warning about using `forall` as an identifier. We might as well quote it now and document in the release notes.
Reduce the matrix to versions to 9.{0,2,4,6}
|
@jinwoo could you take a look when you have a sec? |
jinwoo
approved these changes
Dec 23, 2023
ylecornec
pushed a commit
to ylecornec/proto-lens
that referenced
this pull request
Feb 19, 2024
* Minor changes for 9.6: imports and TypeOperators
Bump up some bounds on base which should make this a safe change
on older ghc versions.
* Use Language.Haskell.Syntax.Module.Name on 9.6
* Backward compatibility break: quote `forall`
GHC started warning about using `forall` as an identifier. We might
as well quote it now and document in the release notes.
* Relax version bounds for 9.6
* Rework the CI
Reduce the matrix to versions to 9.{0,2,4,6}
* Temporarily use ghc-source-gen from hackage until it's in stackage
ylecornec
pushed a commit
to ylecornec/proto-lens
that referenced
this pull request
Feb 19, 2024
* Minor changes for 9.6: imports and TypeOperators
Bump up some bounds on base which should make this a safe change
on older ghc versions.
* Use Language.Haskell.Syntax.Module.Name on 9.6
* Backward compatibility break: quote `forall`
GHC started warning about using `forall` as an identifier. We might
as well quote it now and document in the release notes.
* Relax version bounds for 9.6
* Rework the CI
Reduce the matrix to versions to 9.{0,2,4,6}
* Temporarily use ghc-source-gen from hackage until it's in stackage
ylecornec
pushed a commit
to ylecornec/proto-lens
that referenced
this pull request
Feb 19, 2024
* Minor changes for 9.6: imports and TypeOperators
Bump up some bounds on base which should make this a safe change
on older ghc versions.
* Use Language.Haskell.Syntax.Module.Name on 9.6
* Backward compatibility break: quote `forall`
GHC started warning about using `forall` as an identifier. We might
as well quote it now and document in the release notes.
* Relax version bounds for 9.6
* Rework the CI
Reduce the matrix to versions to 9.{0,2,4,6}
* Temporarily use ghc-source-gen from hackage until it's in stackage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The top commit should NOT not be merged. It's only here to confirm the CI is working. Which it is:
https://github.com/blackgnezdo/proto-lens/actions/runs/7284943410