Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: improve logic for issue template closing and add tests #5905

Merged
merged 21 commits into from
Jan 16, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
revert broken change to generative ai
  • Loading branch information
sofisl committed Jan 14, 2025
commit 2c4a276210d8982a7079f08785d28bb43458fcf9
Original file line number Diff line number Diff line change
@@ -604,7 +604,7 @@ describe('v1beta1.GenAiCacheServiceClient', () => {
['cachedContent', 'name']
);
request.cachedContent.name = defaultValue1;
const expectedHeaderRequestParams = `cached_content.name=${defaultValue1}`;
const expectedHeaderRequestParams = `cached_content.name=${defaultValue1 ?? ''}`;
const expectedResponse = generateSampleMessage(
new protos.google.cloud.aiplatform.v1beta1.CachedContent()
);
@@ -638,7 +638,7 @@ describe('v1beta1.GenAiCacheServiceClient', () => {
['cachedContent', 'name']
);
request.cachedContent.name = defaultValue1;
const expectedHeaderRequestParams = `cached_content.name=${defaultValue1}`;
const expectedHeaderRequestParams = `cached_content.name=${defaultValue1 ?? ''}`;
const expectedResponse = generateSampleMessage(
new protos.google.cloud.aiplatform.v1beta1.CachedContent()
);
@@ -687,7 +687,7 @@ describe('v1beta1.GenAiCacheServiceClient', () => {
['cachedContent', 'name']
);
request.cachedContent.name = defaultValue1;
const expectedHeaderRequestParams = `cached_content.name=${defaultValue1}`;
const expectedHeaderRequestParams = `cached_content.name=${defaultValue1 ?? ''}`;
const expectedError = new Error('expected');
client.innerApiCalls.updateCachedContent = stubSimpleCall(
undefined,