feat(gax): introduce RetryPolicy
#572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coryan
force-pushed
the
feat-gax-retry-loop-pr3
branch
from
d92ba0d to
5ffb6c1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #572 +/- ##
==========================================
+ Coverage 72.71% 74.50% +1.78%
==========================================
Files 30 31 +1
Lines 1085 1161 +76
==========================================
+ Hits 789 865 +76
Misses 296 296 ☔ View full report in Codecov by Sentry. |
This introduces a trait and some implementations to drive retry loops. The policy controls for how long the retry loop runs, and what errors are considered retryable.
coryan
force-pushed
the
feat-gax-retry-loop-pr3
branch
from
7fa038d to
0483843
Compare
codyoss
reviewed
Jan 3, 2025
codyoss
approved these changes
Jan 3, 2025
| @@ -89,63 +89,119 @@ impl RetryFlow { | |||
| /// | |||
| /// Implementations of this trait determine if errors are retryable, and for how | |||
| /// long the retry loop may continue. | |||
| pub trait RetryPolicy: Send + Sync { | |||
| pub trait RetryPolicy: Send + Sync + std::fmt::Debug { | |||
There was a problem hiding this comment.
I wonder if this trait should have a now method for clock manipulation. We could provide a default.
There was a problem hiding this comment.
I started making this change the the tests looked more complicated. Maybe I am holding this wrong. We can try again in a future PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a trait and some implementations to drive retry loops.
The policy controls for how long the retry loop runs, and what errors
are considered retryable.
Part of the work for #437. #565 maybe give you a more complete picture of where this is going.