Skip to content
This repository has been archived by the owner on Mar 13, 2018. It is now read-only.

this is not guaranteed to be the root scope #203

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

this is not guaranteed to be the root scope #203

wants to merge 1 commit into from

Conversation

timoxley
Copy link
Contributor

Better to be explicit and use window.

@timoxley
this is not guaranteed to be the root scope
b01822a 
Better to be explicit and use `window`.
@timoxley
Copy link
Contributor Author

Value of this heavily depends on context where the code is loaded. Not everyone is loading via script tags.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timoxley @addyosmani