Change asserts to manually raising AssertionError #947
+169
−103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See graphql-python/graphql-core#244 for discussion of why this change is needed. The issue exists in several
graphql-python
projects (graphql-core
,graphene
,graphene-django
), but biting this one off first as it was smaller than the changes needed ingraphql-core
.Ideally the usage of
AssertionError
would be dropped in favor ofTypeError
andValueError
, but that would have to wait for a new major version release as it's a backwards incompatible change.