This repository has been archived by the owner on Mar 10, 2024. It is now read-only.

Fixed share URL, excerpt and Comments #95

Open

esandez93 wants to merge 2 commits into greglobinski:master from esandez93:master

esandez93 commented Oct 2, 2019 •

edited

Loading

The URL was ending on "undefined" because pathPrefix is not set.
The Share component was not receiving the excerpt so it was "undefined" when sharing.
The yarn.lock was breaking the installation and the only solution has been deleting it and creating it again.
The Comments component was causing an error when the FB_APP_ID was not being set, so now it checks it before showing the component.

Fixes #73

esandez93 added 2 commits

October 2, 2019 12:37


          Fixed share URL and excerpt

a159222


          Removed Comments component when the appId is not set

5ef22f6

esandez93 changed the title ~~Fixed share URL and excerpt~~ Fixed share URL, excerpt and Comments

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet