Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cannot upgrade gsk 1.29 to gsk 1.30 due to version validation #405

Merged
merged 2 commits into from
Jan 2, 2025
Merged

Fix cannot upgrade gsk 1.29 to gsk 1.30 due to version validation #405

merged 2 commits into from
Jan 2, 2025

Conversation

nvthongswansea
Copy link
Member

@nvthongswansea nvthongswansea commented Jan 2, 2025 •
edited
Loading

Change:

  • Remove gsk multi-node-pool feature validation when reading/updating k8s resource (Because we just need to validate the version of k8s for multi-node-pool feature at creation time).

@nvthongswansea nvthongswansea requested a review from alidaw January 2, 2025 15:55
@alidaw
Copy link
Contributor

alidaw commented Jan 2, 2025 •
edited
Loading

LGTM as far as I can see.

@nvthongswansea nvthongswansea merged commit 7209505 into master Jan 2, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alidaw alidaw alidaw approved these changes

Assignees

@nvthongswansea nvthongswansea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nvthongswansea @alidaw