Store two contexts to query later and earlier trips at any time #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed ✔️
|
Tested on Android 13 with DB and SE networks (and DB network Android 5 Emulator) and it works fine :) |
|
Do you want to merge this PR before doing the next 2.2.2 release? (I think it would be nice to release 2.2.2 ~soon, as it will bring a lot of important fixes and network updates.) |
|
I think this could be merged, what do you think @ialokim ? |
|
@ialokim do you think it is ready to be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out PTE does not return a combined trip context, but just the one related to the last query. To be able to query both later and earlier trips at anytime, this PR proposes to save both the context of the earliest and the latest trips.
Fixes #824