Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump targetSdk to 34 #968

Merged
merged 1 commit into from
Dec 1, 2024
Merged

Bump targetSdk to 34 #968

merged 1 commit into from
Dec 1, 2024

Conversation

Altonss
Copy link
Collaborator

@Altonss Altonss commented Nov 28, 2024

Only concern I had about this is https://developer.android.com/about/versions/14/behavior-changes-14#safer-intents, but I think it's fine :) (but it would be great @ialokim if you could have a quick look).
Fixes #967

(Works well on Android 13 and Android 5 emulator)

@Altonss Altonss added beginner job 🔰 This is a relatively easy task suitable for new contributors. priority 🚨️ This issue will be most probably addressed before the next release. labels Nov 28, 2024
@Altonss Altonss added this to the 2.2.2 milestone Nov 28, 2024
@Altonss Altonss requested a review from ialokim November 28, 2024 16:43
@cla-bot cla-bot bot added the cla-signed ✔️ The Contributor Licence Agreement was signed by all contributors. label Nov 28, 2024
@Altonss
Copy link
Collaborator Author

Altonss commented Dec 1, 2024

Works fine on Android 14 emulator, so I'm going to merge this now.
Feel free to comment/open an issue if there is anything about this change you wish to discuss :)

@Altonss Altonss merged commit 9d1fa8a into grote:master Dec 1, 2024
4 checks passed
@Altonss Altonss deleted the targetSdk34 branch December 7, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginner job 🔰 This is a relatively easy task suitable for new contributors. cla-signed ✔️ The Contributor Licence Agreement was signed by all contributors. priority 🚨️ This issue will be most probably addressed before the next release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Target Android 34 SDK
1 participant