Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add meme sources #182

Merged
merged 6 commits into from
Nov 8, 2019
Merged

Add meme sources #182

merged 6 commits into from
Nov 8, 2019

Conversation

Miftahunajat
Copy link
Contributor

@Miftahunajat Miftahunajat commented Oct 20, 2019 •
edited
Loading

Fixes #126

@Miftahunajat Miftahunajat mentioned this pull request Oct 20, 2019
Closed
@gsantner gsantner self-requested a review October 20, 2019 09:37
gsantner
gsantner requested changes Oct 20, 2019
View reviewed changes
Copy link
Owner

@gsantner gsantner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Miftahunajat
Thanks but there was already a PR (#181) for different file with list.

Can you please instead of new file, edit meme_sources.md and add links that are missing compared to your list?

Thanks!

@Miftahunajat
Copy link
Contributor Author

sorry I did not pay attention to this Pull Request.
Thank you, does this PR closed or I still can update this PR to update meme sources

@gsantner
Copy link
Owner

yes you can update

@Miftahunajat
Copy link
Contributor Author

Hello @gsantner I already updated this current Pull Request with few sources of meme.
Please look at it
Thank you

@Miftahunajat
Copy link
Contributor Author

I there anything may i add ? @gsantner

@gsantner
Copy link
Owner

If you think it fits, yes

@gsantner gsantner self-requested a review October 24, 2019 20:20
gsantner
gsantner approved these changes Oct 24, 2019
View reviewed changes
Copy link
Owner

@gsantner gsantner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

@Miftahunajat
Copy link
Contributor Author

Thank you

@gsantner gsantner merged commit 48dd9c7 into gsantner:master Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsantner gsantner gsantner approved these changes

Assignees

@Miftahunajat Miftahunajat

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document: List of Funny & Meme sites (/r/memes, 9gag etc)
2 participants
@Miftahunajat @gsantner