feat(commenting): Add commentingEnabled flag to control PR commenting
#184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a repository builds for multiple Riff-Raff projects, receiving multiple comments (one per Riff-Raff project) can become noisy. This change introduces a flag (`commentingEnabled`) to disable comments entirely.
|
cc @rupertbates as author of guardian/support-service-lambdas#2587 Would welcome your thoughts on this change. |
|
Thanks to @rupertbates for testing this in guardian/support-service-lambdas#2597. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
If a repository builds for multiple Riff-Raff projects, receiving multiple comments (one per Riff-Raff project) can become noisy. For example guardian/support-service-lambdas#2587.
This change introduces a flag (
commentingEnabled) to disable comments entirely. By defaultcommentingEnabledis set to'true'.Note: this is more of a pragmatic change as in the ideal we'd still provide the deployment links, but grouped together under a single comment.