Parameterise cpuArchitecture for GuEcsTask #2486
Conversation
🦋 Changeset detectedLatest commit: 568165a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
philmcmahon
force-pushed
the
ecs-task-cpu-architecture
branch
from
689ee93 to
e686804
Compare
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@guardian/cdk": major | |||
There was a problem hiding this comment.
Is this really a breaking change? Or is it a minor?
There was a problem hiding this comment.
It's breaking because the previous default was to use X86 rather than ARM
There was a problem hiding this comment.
Ah! Hadn't spotted that. Are there any scenarios where we'd ever use x86? I wonder if a "paved road" solution would be to not expose cpuArchitecture at all. Where a service not be be ARM compatible, it'll use an escape hatch to change the architecture.
There was a problem hiding this comment.
Sorry I missed this! Sounds good, have updated
philmcmahon
force-pushed
the
ecs-task-cpu-architecture
branch
from
76d3665 to
93510f3
Compare
philmcmahon
force-pushed
the
ecs-task-cpu-architecture
branch
from
93510f3 to
568165a
Compare
What does this change?
Previously we could only launch x86 ecs tasks. This resolves that.
Note - @akash1810 suggested pulling the ecs task out of GuCDK since it's only used by investigations. V happy to do this but in the short term it would be helpful to have this extra configuration property
How to test
I've tested this by deploying to a project in the investigations account.