Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop loading the cmp if user is on info page #1847

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

akinsola-guardian
Copy link
Contributor

@akinsola-guardian akinsola-guardian commented Dec 10, 2024

What are you changing?

  • Preventing the CMP banner from loading on informational pages.
  • Configuring the excludePage as a targeting parameter for Sourcepoint.

Why?

  • The CMP banner should not show on info pages.

Copy link

changeset-bot bot commented Dec 10, 2024

🦋 Changeset detected

Latest commit: 68d0b13

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@github-actions github-actions bot added 📦 npm Affects a @guardian package on NPM @guardian/libs labels Dec 10, 2024
@akinsola-guardian akinsola-guardian added the 🐥 Canaries Triggers canary releases of any packages with changesets waiting. label Dec 11, 2024
Copy link
Contributor

Note

The following canaries were published to NPM:

🐥

Copy link
Contributor

Note

The following canaries were published to NPM:

🐥

Copy link
Contributor

Note

The following canaries were published to NPM:

🐥

@akinsola-guardian akinsola-guardian changed the title White list info section Stop loading the cmp if user is on info page Dec 19, 2024
@akinsola-guardian akinsola-guardian removed the 🐥 Canaries Triggers canary releases of any packages with changesets waiting. label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@guardian/libs 📦 npm Affects a @guardian package on NPM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant