Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mob/tabbing around the crossword #1875

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

oliverabrahams
Copy link
Contributor

What are you changing?

  • Controlling focus within the crossword.
  • When pressing Tab, move forward in the crossword - across, grid, down, controls

Why?

  • This means it is easier to navigate the crossword for screen readers and accessibility reasons, You are only one tab from the clues to the grid. This also allows for our custom layout with the same tab order. no matter which order the components are in

@oliverabrahams oliverabrahams requested a review from a team as a code owner December 31, 2024 12:28
Copy link

changeset-bot bot commented Dec 31, 2024

⚠️ No Changeset found

Latest commit: 20a8c57

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@github-actions github-actions bot added the 📦 npm Affects a @guardian package on NPM label Dec 31, 2024
@oliverabrahams oliverabrahams added the run_chromatic Runs chromatic when label is applied label Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant