Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grid a11y format label #1895

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

Grid a11y format label #1895

wants to merge 27 commits into from
+82 −30

Conversation

oliverabrahams
Copy link
Contributor

What are you changing?

  • Adding an aria label that describes the cell you are on.
    • The label is in the format Letter 2 of 4-across: Life is in a mess (5 letters). Also, letter 1 of 5-down Life is always in a mess (2 letters).

Why?

  • This will give screen readers all the info needed to fill in a cell.

sndrs and others added 20 commits January 9, 2025 10:41
@sndrs
WIP
25f0823
@sndrs
woops
bfdc8df
@oliverabrahams
Screen reader focus keyboard grid
e649c0d
@sndrs
a million updates
a3a56b6
@sndrs
focus the first cell when you select a clue
a9ca9cf
@sndrs
use activeElement for focus checking when curretnEntyryId changes
c8417da
@oliverabrahams
make all the empty white cells have inputs. Uses the platform. Better…
8e63121 
… for A11y.
@oliverabrahams
remove .table
483a26b
@oliverabrahams
Merge branch 'sndrs/grid-a11y' into oa/grid-a11y-multiple-inputs
d250c35
@oliverabrahams
remove forwarded ref from cell
6548445
@oliverabrahams
fix TS issues
a0326a7
@oliverabrahams
handle click instead of focus
fd4acbd
@oliverabrahams
Clicking on a current cell changes the entry if possible
fc4e33b
@oliverabrahams
strip HTML
da3762b
@oliverabrahams
undo changes to description
65853a5
@oliverabrahams
Merge branch 'oa/grid-a11y-multiple-inputs' into oa/grid-a11y-format-…
703b042 
…label
@oliverabrahams
add proper label to cell input
a92c226
@oliverabrahams
Merge branch 'oa/grid-a11y-multiple-inputs' into oa/grid-a11y-handle-…
bc7e0b8 
…click
@oliverabrahams
Merge branch 'oa/grid-a11y-handle-click' into oa/grid-a11y-format-label
ed25f0f
@oliverabrahams
give order to cell description so the labels do not change. Makes for…
b6e933d 
… a more consistent experience
@oliverabrahams oliverabrahams requested a review from a team as a code owner January 15, 2025 16:38
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 15, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: a6e4dbc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@github-actions github-actions bot added the 📦 npm Affects a @guardian package on NPM label Jan 15, 2025
@oliverabrahams oliverabrahams requested a review from arelra January 22, 2025 14:01
Base automatically changed from oa/grid-a11y-handle-click to main January 22, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arelra arelra Awaiting requested review from arelra

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
📦 npm Affects a @guardian package on NPM
Projects
None yet
Milestone
Decommission Frontend Rendering
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverabrahams @arelra @sndrs