Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CAPI Scala Client -> 26.0.0 #313

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Update CAPI Scala Client -> 26.0.0 #313

merged 1 commit into from
Apr 3, 2024

Conversation

Fweddi
Copy link
Contributor

@Fweddi Fweddi commented Apr 3, 2024

What does this change?

This brings in the new timeline element (guardian/content-api-scala-client#414) - see also guardian/content-api-models#245.

This brings in the timeline element changes (guardian/content-api-scala-client#414)
Copy link

@simonbyford simonbyford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excuse the dumb question but what are the implications of this change? Has is been (/can it be) tested?

@alinaboghiu
Copy link
Member

For the facia client there should be no implications as fronts will never directly use this new element, but because it's a major version change we need to update the fapi client to prevent dependency version conflicts in places like Frontend that use both libraries. I think.

@Fweddi Fweddi merged commit b4ec286 into main Apr 3, 2024
1 check passed
@Fweddi Fweddi deleted the fp/timeline-element branch April 3, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants